Messages in this thread | | | From | Bjørn Mork <> | Subject | Re: [PATCH v2 2/3] usb: core: Allow subclassed USB drivers to override usb_choose_configuration() | Date | Sat, 02 Dec 2023 20:11:17 +0100 |
| |
Douglas Anderson <dianders@chromium.org> writes:
> The r8152 driver tried to make things work by implementing a USB > generic_subclass driver and then overriding the normal config > selection after it happened. This is less than ideal and also caused > breakage if someone deauthorized and re-authorized the USB device > because the USB core ended up going back to it's default logic for > choosing the best config. I made an attempt to fix this [1] but it was > a bit ugly. > > Let's do this better and allow USB generic_subclass drivers to > override usb_choose_configuration(). > > [1] https://lore.kernel.org/r/20231130154337.1.Ie00e07f07f87149c9ce0b27ae4e26991d307e14b@changeid > > Suggested-by: Alan Stern <stern@rowland.harvard.edu> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
Brilliant! Thanks for doing this. It is obviously what I should have done in the first place if I had been smart enough.
Bjørn
| |