Messages in this thread | | | Date | Tue, 19 Dec 2023 17:06:33 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 1/2] gpiolib: drop tabs from local variable declarations |
| |
On Tue, Dec 19, 2023 at 03:23:22PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Older code has an annoying habit of putting tabs between the type and the > name of the variable. This doesn't really add to readability and newer > code doesn't do it so make the entire file consistent. > > While at it: convert 'unsigned' to 'unsigned int'.
Not a big change to be a burden for backporting I suppose. Code wise looks good to me, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> + struct gpio_chip *gc = desc->gdev->chip; > + int ret; > + unsigned long flags; > + unsigned int offset;
I'm wondering if you can make it reversed xmas tree order. This will make it even more consistent between functions.
...
> + bool ret = false; > + unsigned long flags; > + struct gpio_chip *gc;
Ditto.
...
> + struct gpio_chip *gc = gdev->chip; > + struct gpio_desc *desc;
(okay with above, but...)
> + unsigned int gpio = gdev->base;
> + int value;
Ditto.
> + bool is_out; > + bool is_irq; > + bool active_low;
And ditto.
-- With Best Regards, Andy Shevchenko
| |