Messages in this thread | | | Date | Tue, 19 Dec 2023 09:45:03 +0800 | Subject | Re: [PATCH V3 net-next 4/4] net: hns3: move constants from hclge_debugfs.h to hclge_debugfs.c | From | Jijie Shao <> |
| |
on 2023/12/18 23:35, Simon Horman wrote: > On Sat, Dec 16, 2023 at 03:00:18PM +0800, Jijie Shao wrote: >> some constants are defined in hclge_debugfs.h, >> but only used in hclge_debugfs.c. >> so move them from hclge_debugfs.h to hclge_debugfs.c. >> >> Signed-off-by: Jijie Shao <shaojijie@huawei.com> > Thanks Jijie, > > this looks good, but I think it should come before patch 2/4, > to avoid warnings about unused symbols being flagged until this patch is > applied. > > ...
Thanks for your suggestion, this will be fixed in v4.
| |