Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 19 Dec 2023 16:58:07 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 5/6] platform: Modify platform_get_irq_optional() to use resource |
| |
On Mon, Dec 18, 2023 at 01:23:35PM -0700, Mark Hasemeyer wrote:
...
> > Consider combine the above to use fwnode_irq_get() in the separate prerequisite > > change. > > I like the idea. It doesn't look like 'struct fwnode_operations' > provides a way to retrieve information in a 'struct resource' format.
It can be added, but it's orthogonal to this series. What I suggest is to unify them here followed by your patch in this series. I.o.w. add one more patch as a prerequisite.
> Perhaps this could be followed up on in a separate patch train?
Definitely, but again, not (directly) related to this series.
...
> > > + irqd_set_trigger_type(irqd, r->flags & IORESOURCE_BITS); > > > > NIH resource_type(). > > > > > + } > > > return ret; > > Does NIH mean "not invented here"?
Yes.
> resource_type() masks > IORESOURCE_TYPE_BITS, not IORESOURCE_BITS. I'm not quite sure what you > mean here.
Ah, my bad, indeed, you are right.
-- With Best Regards, Andy Shevchenko
| ![\](/images/icornerr.gif) |