Messages in this thread | | | From | Javier Martinez Canillas <> | Subject | Re: [PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers | Date | Tue, 19 Dec 2023 15:29:43 +0100 |
| |
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
Hello Krzysztof,
> On 19/12/2023 12:20, Javier Martinez Canillas wrote:
[...]
>>>> +allOf: >>>> + - $ref: solomon,ssd-common.yaml# >>>> +
[...]
>>> >>> + width: >>> + default: 96 >>> + >>> + height: >>> + default: 64 > > Which also looks wrong on its own. Where is the definition of these
Yes, I already discussed this with Conor and mentioned to him that is a typo but already fixed it locally and I'm testing with the correct ones.
> properties? IOW, where do they come from? >
The "solomon,width" and "solomon,height" properties are defined in the solomon,ssd-common.yaml binding schema file that is referenced.
>>> + >> >> ...but when trying move the default for the "solomon,width" and >> "solomon,height" to the properties section, make dt_binding_check >> complains as follows: > > Worked for me. >
Oh, that's good to know. I wonder what's the difference...
> ... > >> DTC_CHK Documentation/devicetree/bindings/display/solomon,ssd133x.example.dtb >> >> The warning goes away if I follow the hints and add a type and description >> to the properties, i.e: > > Hm, I wonder what's different in your case. I assume you run the latest > dtschema. >
Not the latest but had a recent one. I've updated it, so I do now :)
$ pip list | grep dtschema dtschema 2023.9
$ pip install --upgrade dtschema
$ pip list | grep dtschema dtschema 2023.11
[...]
>> But that would duplicate information that is already present in the >> included solomon,ssd-common.yaml schema. Do you know what is the proper >> way to do this? > > Works for me, so please paste somewhere proper diff so we can compare. >
With the latest dtschema version it works indeed. Thanks for the pointer!
$ make W=1 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/solomon,ssd133x.yaml LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTEX Documentation/devicetree/bindings/display/solomon,ssd133x.example.dts DTC_CHK Documentation/devicetree/bindings/display/solomon,ssd133x.example.dtb
> Best regards, > Krzysztof >
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |