lkml.org 
[lkml]   [2023]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6.8 1/2] nvmem: layouts: refactor .add_cells() callback arguments
    > From: Rafał Miłecki <rafal@milecki.pl>
    >
    > Simply pass whole "struct nvmem_layout" instead of single variables.
    > There is nothing in "struct nvmem_layout" that we have to hide from
    > layout drivers. They also access it during .probe() and .remove().
    >
    > Thanks to this change:
    >
    > 1. API gets more consistent
    > All layouts drivers callbacks get the same argument
    >
    > 2. Layouts get correct device
    > Before this change NVMEM core code was passing NVMEM device instead
    > of layout device. That resulted in:
    > * Confusing prints
    > * Calling devm_*() helpers on wrong device
    > * Helpers like of_device_get_match_data() dereferencing NULLs
    >
    > 3. It gets possible to get match data
    > First of all nvmem_layout_get_match_data() requires passing "struct
    > nvmem_layout" which .add_cells() callback didn't have before this.
    > It
    > doesn't matter much as it's rather useless now anyway (and will be
    > dropped).
    > What's more important however is that of_device_get_match_data() can
    > be used now thanks to owning a proper device pointer.
    >
    > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

    LGTM,
    Reviewed-by: Michael Walle <michael@walle.cc>

    \
     
     \ /
      Last update: 2023-12-19 13:25    [W:6.204 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site