Messages in this thread | | | Date | Tue, 19 Dec 2023 12:58:58 +0100 | Subject | Re: [PATCH v6 5/6] nvme: add csi, ms and nuse to sysfs | From | Hannes Reinecke <> |
| |
On 12/18/23 17:59, Daniel Wagner wrote: > libnvme is using the sysfs for enumarating the nvme resources. Though > there are few missing attritbutes in the sysfs. For these libnvme issues > commands during discovering. > > As the kernel already knows all these attributes and we would like to > avoid libnvme to issue commands all the time, expose these missing > attributes. > > The nuse value is updated on request because the nuse is a volatile > value. Since any user can read the sysfs attribute, a very simple rate > limit is added (update once every 5 seconds). A more sophisticated > update strategy can be added later if there is actually a need for it. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Sagi Grimberg <sagi@grimberg.me> > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > drivers/nvme/host/core.c | 6 ++- > drivers/nvme/host/nvme.h | 6 +++ > drivers/nvme/host/sysfs.c | 85 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 96 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich
| |