Messages in this thread | | | Date | Tue, 19 Dec 2023 12:39:43 +0100 | Subject | Re: [PATCH v3 13/16] nvmet-fc: abort command if when there is binding | From | Hannes Reinecke <> |
| |
On 12/18/23 16:31, Daniel Wagner wrote: > WHen the target port has not active port binding, there is no point in > trying to process the command as it has to fail anyway. Instead adding > checks to all commands abort the command early. > Please fix up the subject: 'abort command when there is no binding'
> Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > drivers/nvme/target/fc.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c > index 47cecc8c72b2..663c51c9fe53 100644 > --- a/drivers/nvme/target/fc.c > +++ b/drivers/nvme/target/fc.c > @@ -1101,6 +1101,9 @@ nvmet_fc_alloc_target_assoc(struct nvmet_fc_tgtport *tgtport, void *hosthandle) > int idx; > bool needrandom = true; > > + if (!tgtport->pe) > + return NULL; > + > assoc = kzalloc(sizeof(*assoc), GFP_KERNEL); > if (!assoc) > return NULL; > @@ -2520,8 +2523,9 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *tgtport, > > fod->req.cmd = &fod->cmdiubuf.sqe; > fod->req.cqe = &fod->rspiubuf.cqe; > - if (tgtport->pe) > - fod->req.port = tgtport->pe->port; > + if (!tgtport->pe) > + goto transport_error; > + fod->req.port = tgtport->pe->port; > > /* clear any response payload */ > memset(&fod->rspiubuf, 0, sizeof(fod->rspiubuf));
Otherwise:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich
| |