Messages in this thread | | | Date | Tue, 19 Dec 2023 08:14:39 +0800 | Subject | Re: [PATCH v3 1/8] dt-bindings: arm: Add support for CMB element size | From | Tao Zhang <> |
| |
On 11/21/2023 3:24 PM, Krzysztof Kozlowski wrote: > On 21/11/2023 03:24, Tao Zhang wrote: >> Add property "qcom,cmb-elem-size" to support CMB(Continuous >> Multi-Bit) element for TPDM. The associated aggregator will read >> this size before it is enabled. CMB element size currently only >> supports 32-bit and 64-bit. > >> qcom,dsb-msrs-num: >> description: >> Specifies the number of DSB(Discrete Single Bit) MSR(mux select register) >> @@ -110,4 +119,23 @@ examples: >> }; >> }; >> >> + tpdm@6c29000 { >> + compatible = "qcom,coresight-tpdm", "arm,primecell"; >> + reg = <0x06c29000 0x1000>; >> + reg-names = "tpdm-base"; >> + >> + qcom,cmb-element-size = /bits/ 8 <64>; > One new property usually does not justify new example. Why it cannot be > added to existing example?
Because the existing example tpdm "tpdm@684c000" which only supports dsb sub-unit. Most
TPDMs only support one type of sub-unit.
> > Anyway, I prefer not to take any new Qualcomm Coresight bindings or > Qualcomm SoC DTS nodes with Coresight till we fix all existing warnings. > I don't know how to fix them, so I need help with them. No such fixing > happened so far from Qcom, so pushback is my only way to get any attention. > > I already commented on this in other email thread.
Jinlong has fixed the warnings from coresight bindings. I will prepare my next patch
series soon.
Best,
Tao
> > Best regards, > Krzysztof >
| |