Messages in this thread | | | Date | Tue, 19 Dec 2023 10:35:54 +0100 | From | Dimitri Fedrau <> | Subject | Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY |
| |
Am Tue, Dec 19, 2023 at 10:19:41AM +0100 schrieb Stefan Eichenberger: > On Tue, Dec 19, 2023 at 09:11:17AM +0100, Dimitri Fedrau wrote: > > > I could add the init sequence for the 88Q2221 PHY. Then you could test > > it on your side. Would this be helpful to you ? Did you already have the > > chance to test the patch ? > > Unfortunately I haven't had time to test it yet. I will try to do it on > Thursday, otherwise sadly it will be next year. > Ok.
> > You are right, but I would propose to stick to the reference init > > sequence and make sure the PHYs works with our code and then work on > > optimizing the code. We still can remove and/or document parts of it. > > I am not sure that it will be accepted by the maintainers if you use a > lot of registers that are not documented. For this reason, keeping it to > a minimum might increase the chances of it being accepted. > Ok. Will try to reduce them.
> > Are you trying with the patch I provided or your own code ? If you use > > my patch you should wait until V3, because I found some problems with > > it. Switching from 1000Mbit/s to 100Mbit/s in autonegotiation mode doesn't > > work. I could fix it but the fix touches some code already upstreamed. So > > I tried to push parts of it yesterday. I forgot to cc you, just used the > > get_maintainer script. I will add you to the cc list. Until then you can > > look it up here: 20231218221814.69304-2-dima.fedrau@gmail.com > > I used my own code so far but I will try again with your patches. Maybe > send this and the other patches as a whole series so that it gets clear > why you need the changes as Andrew wrote. > Ok. Will send an V3 including all patches.
> Regards, > Stefan
Regards, Dimitri
| |