lkml.org 
[lkml]   [2023]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] mm: fix arithmetic for max_prop_frac when setting max_ratio
On Tue, Dec 19, 2023 at 10:42:46AM +0800, Jingbo Xu wrote:
> } else {
> bdi->max_ratio = max_ratio;
> - bdi->max_prop_frac = (FPROP_FRAC_BASE * max_ratio) / 100;
> + bdi->max_prop_frac = div64_u64(FPROP_FRAC_BASE * max_ratio,
> + 100 * BDI_RATIO_SCALE);
> }

Why use div64_u64 here?

FPROP_FRAC_BASE is an unsigned long. max_ratio is an unsigned int, so
the numerator is an unsigned long. BDI_RATIO_SCALE is 10,000, so the
numerator is an unsigned int. There's no 64-bit arithmetic needed here.

\
 
 \ /
  Last update: 2023-12-19 05:07    [W:0.062 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site