lkml.org 
[lkml]   [2023]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 7/7] cxl/memdev: Register for and process CPER events
    Dan Williams wrote:
    > Ira Weiny wrote:
    > [..]
    > > > and drop the = NULL above.
    > >
    > > Done.
    >
    > The NULL assignment was more about making it clear that
    > __free(pci_dev_put) will take no action until the pdev is acquired.
    > Otherwise, any future refactoring that introduces a 'return' before
    > @pdev is acquired needs to be careful to assign @pdev to NULL. So, just
    > include it in the declaration more as a __free() declaration style issue
    > than a correctness issue.

    I think he meant the assignment to cxlds. At least that is the NULL
    assignment I took out.

    Ira

    \
     
     \ /
      Last update: 2023-12-20 01:30    [W:9.113 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site