Messages in this thread | | | Date | Tue, 19 Dec 2023 19:24:24 +0100 | From | Greg KH <> | Subject | Re: [PATCH v4 2/2] lib/string: shrink lib/string.i via IWYU |
| |
On Tue, Dec 19, 2023 at 06:09:52PM +0000, Tanzir Hasan wrote: > This diff uses an open source tool include-what-you-use (IWYU) to modify > the include list changing indirect includes to direct includes. > IWYU is implemented using the IWYUScripts github repository which is a tool that is > currently undergoing development. These changes seek to improve build times. > > This change to lib/string.c resulted in a preprocessed size of > lib/string.i from 26371 lines to 5321 lines (-80%) for the x86 > defconfig.
Nit, use 72 columns like your editor is trying to force on you when you write a git commit. As is, these line-ends are all over the place.
It's the stuff around the actual change that is hard to get right...
thanks,
greg k-h
| |