Messages in this thread Patch in this message | | | Date | Tue, 19 Dec 2023 19:13:03 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] driver core: mark remaining local bus_type variables as const |
| |
On Tue, Dec 19, 2023 at 06:02:33PM +0000, Ertman, David M wrote: > > -----Original Message----- > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Sent: Tuesday, December 19, 2023 7:35 AM > > To: rafael@kernel.org; linux-kernel@vger.kernel.org > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Ertman, David M > > <david.m.ertman@intel.com>; Weiny, Ira <ira.weiny@intel.com>; William > > Breathitt Gray <william.gray@linaro.org>; David Hildenbrand > > <david@redhat.com>; Oscar Salvador <osalvador@suse.de>; Kevin Hilman > > <khilman@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; Brown, Len > > <len.brown@intel.com> > > Subject: [PATCH] driver core: mark remaining local bus_type variables as > > const > > > > Now that the driver core can properly handle constant struct bus_type, > > change the local driver core bus_type variables to be a constant > > structure as well, placing them into read-only memory which can not be > > modified at runtime. > > > > Cc: Dave Ertman <david.m.ertman@intel.com> > > Cc: Ira Weiny <ira.weiny@intel.com> > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > > Cc: William Breathitt Gray <william.gray@linaro.org> > > Cc: David Hildenbrand <david@redhat.com> > > Cc: Oscar Salvador <osalvador@suse.de> > > Cc: Kevin Hilman <khilman@kernel.org> > > Cc: Ulf Hansson <ulf.hansson@linaro.org> > > Cc: Len Brown <len.brown@intel.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/base/auxiliary.c | 2 +- > > drivers/base/isa.c | 2 +- > > drivers/base/memory.c | 2 +- > > drivers/base/node.c | 2 +- > > drivers/base/power/domain.c | 2 +- > > drivers/base/soc.c | 2 +- > > 6 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c > > index 4d4c2c8d26c4..d3a2c40c2f12 100644 > > --- a/drivers/base/auxiliary.c > > +++ b/drivers/base/auxiliary.c > > @@ -244,7 +244,7 @@ static void auxiliary_bus_shutdown(struct device > > *dev) > > auxdrv->shutdown(auxdev); > > } > > > > -static struct bus_type auxiliary_bus_type = { > > +static const struct bus_type auxiliary_bus_type = { > > .name = "auxiliary", > > .probe = auxiliary_bus_probe, > > .remove = auxiliary_bus_remove, > > diff --git a/drivers/base/isa.c b/drivers/base/isa.c > > index 675ad3139224..e23d0b49a793 100644 > > --- a/drivers/base/isa.c > > +++ b/drivers/base/isa.c > > LGTM - ACK
So, is that an "Acked-by:" type response? We need something standard for our tools to pick up...
thanks,
greg k-h
| |