Messages in this thread | | | Date | Tue, 19 Dec 2023 18:23:32 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v2] i2c: rk3x: fix potential spinlock recursion on poll |
| |
On Thu, Dec 07, 2023 at 04:21:59PM +0800, Jensen Huang wrote: > Possible deadlock scenario (on reboot): > rk3x_i2c_xfer_common(polling) > -> rk3x_i2c_wait_xfer_poll() > -> rk3x_i2c_irq(0, i2c); > --> spin_lock(&i2c->lock); > ... > <rk3x i2c interrupt> > -> rk3x_i2c_irq(0, i2c); > --> spin_lock(&i2c->lock); (deadlock here) > > Store the IRQ number and disable/enable it around the polling transfer. > This patch has been tested on NanoPC-T4. > > Signed-off-by: Jensen Huang <jensenhuang@friendlyarm.com> > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Applied to for-current, thanks!
But I'd like to see the follow-up patches somewhen which have been discussed in this thread.
[unhandled content-type:application/pgp-signature] | |