Messages in this thread | | | Date | Mon, 18 Dec 2023 11:55:47 -0600 | From | Lucas De Marchi <> | Subject | Re: [PATCH 1/1] fault-inject: Include linux/types.h by default. |
| |
+Andrew
On Wed, Aug 16, 2023 at 07:17:48PM +0530, Himal Prasad Ghimiray wrote: >Functions should_fail_alloc_page, should_failslab, and __should_failslab >are declared irrespective of CONFIG_FAULT_INJECTION. These functions use >bool and gfp_t types, which are treated as unknown when >CONFIG_FAULT_INJECTION is disabled because the inclusion of linux/types.h >is missing. > >Fixes: 6ff1cb355e62 ("[PATCH] fault-injection capabilities infrastructure") > >Cc: Lucas De Marchi <lucas.demarchi@intel.com> >Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >Cc: Badal Nilawar <badal.nilawar@intel.com> >Cc: Akinobu Mita <akinobu.mita@gmail.com> >Cc: Jason Gunthorpe <jgg@ziepe.ca> >Cc: Jens Axboe <axboe@kernel.dk> >Cc: Qi Zheng <zhengqi.arch@bytedance.com> >Cc: linux-kernel@vger.kernel.org >Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Andrew, could we take this through our drm-xe-next branch going to drm-next if this looks good to you?
thanks Lucas De Marchi
| |