Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 15 Dec 2023 09:30:35 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v1 3/6] of: irq: add wake capable bit to of_irq_resource() |
| |
On Thu, Dec 14, 2023 at 02:05:16PM -0700, Mark Hasemeyer wrote: > > If a device has multiple interrupts, but none named "wakeup" you are > > saying all the interrupts are wakeup capable. That's not right though. > > Only the device knows which interrupts are wakeup capable. You need: > > > > return wakeindex >= 0 && wakeindex == index; > > I was assuming logic described in the DT bindings: > https://www.kernel.org/doc/Documentation/devicetree/bindings/power/wakeup-source.txt > "Also, if device is marked as a wakeup source, then all the primary > interrupt(s) can be used as wakeup interrupt(s)."
Also not the best wording I think.
Which interrupts are primary interrupts?
If we can't determine which interrupt, then we should just leave it up to the device.
Rob
| ![\](/images/icornerr.gif) |