Messages in this thread | | | From | "Wu, Wentong" <> | Subject | RE: [PATCH 1/2] [v2] mei: fix vsc dependency | Date | Fri, 15 Dec 2023 00:51:42 +0000 |
| |
> From: Arnd Bergmann <arnd@arndb.de> > > CONFIG_INTEL_MEI_VSC_HW can be set to built-in even with CONFIG_MEI=m, > but then the driver is not built because Kbuild never enters the drivers/misc/mei > directory for built-in files, leading to a link > failure: > > ERROR: modpost: "vsc_tp_reset" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_init" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_xfer" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_need_read" [drivers/misc/mei/mei-vsc.ko] undefined! > ERROR: modpost: "vsc_tp_intr_enable" [drivers/misc/mei/mei-vsc.ko] > undefined! > ERROR: modpost: "vsc_tp_intr_synchronize" [drivers/misc/mei/mei-vsc.ko] > undefined! > ERROR: modpost: "vsc_tp_intr_disable" [drivers/misc/mei/mei-vsc.ko] > undefined! > ERROR: modpost: "vsc_tp_register_event_cb" [drivers/misc/mei/mei-vsc.ko] > undefined! > > Add an explicit dependency on CONFIG_MEI that was apparently missing, to > ensure the VSC_HW driver cannot be built-in with MEI itself being a loadable > module. > > Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks
Reviewed-by: Wentong Wu <wentong.wu@intel.com>
> --- > drivers/misc/mei/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index > 858bd701d68c..1e28ca23a74a 100644 > --- a/drivers/misc/mei/Kconfig > +++ b/drivers/misc/mei/Kconfig > @@ -62,6 +62,7 @@ config INTEL_MEI_GSC > > config INTEL_MEI_VSC_HW > tristate "Intel visual sensing controller device transport driver" > + depends on INTEL_MEI > depends on ACPI && SPI > depends on GPIOLIB || COMPILE_TEST > help > -- > 2.39.2
| |