Messages in this thread | | | Date | Fri, 15 Dec 2023 09:13:05 +0100 | Subject | Re: [PATCH 01/13] dt-bindings: clock: google,gs101: fix CMU_TOP gate clock names | From | Krzysztof Kozlowski <> |
| |
On 14/12/2023 11:52, Tudor Ambarus wrote: > The gs101 clock names are derived from the clock register names under > some certain rules. In particular, for the gate clocks the following is > documented and expected in the gs101 clock driver: > > Replace CLK_CON_GAT_CLKCMU with CLK_GOUT_CMU and gout_cmu > Replace CLK_CON_GAT_GATE_CLKCMU with CLK_GOUT_CMU and gout_cmu > > For gates remove _UID _BLK _IPCLKPORT and _RSTNSYNC
I don't understand what it has to do with the bindings.
> > The CMU TOP gate clock names missed to include the required "CMU" > differentiator which will cause name collisions with the gate clock names > of other clock units. Fix the TOP gate clock names and include "CMU" in > their name.
Neither here. Clock names are not related to defines.
> > Fixes: 0a910f160638 ("dt-bindings: clock: Add Google gs101 clock management unit bindings") > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > drivers/clk/samsung/clk-gs101.c | 167 ++++++++++++----------- > include/dt-bindings/clock/google,gs101.h | 144 +++++++++----------
I miss the point why bindings must be changed with driver.
Really, guys, we are milling the first GS101 patches for entire cycle. Almost 3 months. The moment I merge bindings you tell me they are wrong. Few days after merging them.
Best regards, Krzysztof
| |