Messages in this thread | | | From | Vishnu Sankar <> | Date | Fri, 15 Dec 2023 08:14:53 +0900 | Subject | Re: [PATCH v2] platform/x86: thinkpad_acpi: fix for incorrect fan reporting on some ThinkPad systems |
| |
Hi Ilpo,
Thank you for the review.
Vishnu
On Thu, Dec 14, 2023 at 11:53 PM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote: > > On Thu, 14 Dec 2023, Vishnu Sankar wrote: > > > Some ThinkPad systems ECFW use non-standard addresses for fan control > > and reporting. This patch adds support for such ECFW so that it can report > > the correct fan values. > > Tested on Thinkpads L13 Yoga Gen 2 and X13 Yoga Gen 2. > > > > Suggested-by: Mark Pearson <mpearson-lenovo@squebb.ca> > > Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com> > > --- > > -Improvements to comments as requested. > > -Removed the usage of unlikely/likely while reading fan speed. > > -Improved and clearer print statements to match the current style. > > -Changed seq_puts to seq_printf of an unrelated section of the patch. > > -Improved the readability of the code. > > -Added more clearer comments. > > Nice work, thanks. > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > > -- > i.
--
Regards,
Vishnu Sankar +817015150407 (Japan)
| |