Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 15 Dec 2023 19:01:26 -0800 | From | Jakub Kicinski <> | Subject | Re: [RFC PATCH net-next v1 4/4] net: page_pool: use netmem_t instead of struct page in API |
| |
On Fri, 15 Dec 2023 02:11:14 +0000 Shakeel Butt wrote: > > From my POV it has to be the first one. We want to abstract the memory > > type from the drivers as much as possible, not introduce N new memory > > types and ask the driver to implement new code for each of them > > separately. > > Agree with Mina's point. Let's aim to decouple memory types from > drivers.
What does "decouple" mean? Drivers should never convert netmem to pages. Either a path in the driver can deal with netmem, i.e. never touch the payload, or it needs pages.
Perhaps we should aim to not export netmem_to_page(), prevent modules from accessing it directly.
| ![\](/images/icornerr.gif) |