Messages in this thread | | | Subject | Re: [PATCH net-next v2 10/21] net: ravb: Move delay mode set in the driver's ndo_open API | From | Sergey Shtylyov <> | Date | Fri, 15 Dec 2023 22:58:05 +0300 |
| |
On 12/14/23 2:45 PM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Delay parse and set were done in the driver's probe API. As some IP
Parsing and setting?
> variants switch to reset mode (and thus registers' content is lost) when > setting clocks (due to module standby functionality) to be able to > implement runtime PM keep the delay parsing in the driver's probe function > and move the delay apply function to the driver's ndo_open API.
Applying?
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> [...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 5e01e03e1b43..04eaa1967651 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c [...] > @@ -1806,6 +1821,8 @@ static int ravb_open(struct net_device *ndev) > if (info->nc_queues) > napi_enable(&priv->napi[RAVB_NC]); > > + ravb_set_delay_mode(ndev); > +
I suspect this belongs in ravb_dmac_init() now...
> /* Device init */ > error = ravb_dmac_init(ndev); > if (error) [...]
MRB, Sergey
| |