Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 15 Dec 2023 11:12:57 -0800 | Subject | Re: [PATCH 3/3] watchdog: sbsa_gwdt: add support for Marvell ac5 | From | Guenter Roeck <> |
| |
On 12/15/23 10:01, Rob Herring wrote: > On Thu, Dec 14, 2023 at 05:04:14PM +0200, Elad Nachman wrote: >> From: Elad Nachman <enachman@marvell.com> >> >> Add support for Marvell ac5/x variant of the ARM >> sbsa global watchdog. This watchdog deviates from >> the standard driver by the following items: >> >> 1. Registers reside in secure register section. >> hence access is only possible via SMC calls to ATF. >> >> 2. There are couple more registers which reside in >> other register areas, which needs to be configured >> in order for the watchdog to properly generate >> reset through the SOC. >> >> The new Marvell compatibility string differentiates between >> the original sbsa mode of operation and the Marvell mode of >> operation. >> >> Signed-off-by: Elad Nachman <enachman@marvell.com> >> --- >> drivers/watchdog/sbsa_gwdt.c | 247 ++++++++++++++++++++++++++++++++--- > > That's more than half the existing driver... >
... which makes me really unhappy and wonder if it is appropriate to hack up the existing driver that much. it doesn't look like Marvell ac5/x really implements SBSA. Given the large number of device specific deviations, a separate driver may be more appropriate.
Guenter
| ![\](/images/icornerr.gif) |