lkml.org 
[lkml]   [2023]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/11] writeback: Factor out writeback_finish()
On Fri, Dec 15, 2023 at 02:26:39PM +0100, Jan Kara wrote:
> > + /* internal fields used by the ->writepages implementation: */
> > + struct folio_batch fbatch;
> > + pgoff_t done_index;
> > + int err;
> > + unsigned range_whole:1; /* entire file */
>
> Do we really need the range_whole member here? It is trivially derived from
> range_start && range_end and used only in one place in writeback_finish().

Yes, as nothing modified range_start and range_end this should be
easily doable.


\
 
 \ /
  Last update: 2023-12-15 17:55    [W:0.043 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site