Messages in this thread | | | Date | Thu, 9 Nov 2023 17:22:58 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next 1/1] net: stmmac: Add support for HW-accelerated VLAN stripping |
| |
> +static void dwmac4_rx_hw_vlan(struct mac_device_info *hw, > + struct dma_desc *rx_desc, struct sk_buff *skb) > +{ > + if (hw->desc->get_rx_vlan_valid(rx_desc)) { > + u16 vid = (u16)hw->desc->get_rx_vlan_tci(rx_desc); > + > + __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vid); > + } > +}
> +static inline int dwmac4_wrback_get_rx_vlan_tci(struct dma_desc *p) > +{ > + return (le32_to_cpu(p->des0) & RDES0_VLAN_TAG_MASK); > +}
A tci is a u16. If you make this function return a u16, you can avoid the cast.
Andrew
| |