Messages in this thread | | | Date | Thu, 9 Nov 2023 12:47:23 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net v4 3/3] net: ethernet: cortina: Fix MTU max setting |
| |
On Thu, Nov 09, 2023 at 10:03:14AM +0100, Linus Walleij wrote: > The RX max frame size is over 10000 for the Gemini ethernet, > but the TX max frame size is actually just 2047 (0x7ff after > checking the datasheet). Reflect this in what we offer to Linux, > cap the MTU at the TX max frame minus ethernet headers. > > We delete the code disabling the hardware checksum for large > MTUs as netdev->mtu can no longer be larger than > netdev->max_mtu meaning the if()-clause in gmac_fix_features() > is never true. > > Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
| |