| Subject | Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator | From | Paolo Abeni <> | Date | Thu, 09 Nov 2023 09:44:18 +0100 |
| |
On Sun, 2023-11-05 at 18:44 -0800, Mina Almasry wrote: [...] > +void netdev_free_devmem(struct page_pool_iov *ppiov) > +{ > + struct netdev_dmabuf_binding *binding = page_pool_iov_binding(ppiov); > + > + refcount_set(&ppiov->refcount, 1); > + > + if (gen_pool_has_addr(binding->chunk_pool, > + page_pool_iov_dma_addr(ppiov), PAGE_SIZE)) > + gen_pool_free(binding->chunk_pool, > + page_pool_iov_dma_addr(ppiov), PAGE_SIZE);
Minor nit: what about caching the dma_addr value to make the above more readable?
Cheers,
Paolo
|