Messages in this thread | | | From | Shakeel Butt <> | Date | Wed, 8 Nov 2023 15:51:51 -0800 | Subject | Re: [PATCH v2] mm/page_alloc: Dedupe some memcg uncharging logic |
| |
On Wed, Nov 8, 2023 at 8:49 AM Brendan Jackman <jackmanb@google.com> wrote: > > The duplication makes it seem like some work is required before > uncharging in the !PageHWPoison case. But it isn't, so we can simplify > the code a little. > > Note the PageMemcgKmem check is redundant, but I've left it in as it > avoids an unnecessary function call. > > Signed-off-by: Brendan Jackman <jackmanb@google.com>
Thanks for the patch. Actually the PageMemcgKmem/folio_memcg_kmem check should be in memcg_kmem_uncharge_page() and not in __memcg_kmem_uncharge_page(). Anyways, that is orthogonal to this patch.
Acked-by: Shakeel Butt <shakeelb@google.com>
| |