Messages in this thread | | | Date | Wed, 8 Nov 2023 17:48:52 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf test: Add option to change objdump binary |
| |
Em Tue, Nov 07, 2023 at 09:37:32AM +0000, James Clark escreveu: > > > On 03/11/2023 15:41, Ian Rogers wrote: > > On Fri, Nov 3, 2023 at 4:35 AM James Clark <james.clark@arm.com> wrote: > > > > > > All of the other Perf subcommands that use objdump have an option to > > > specify the binary, so add the same option to perf test. > > > > > > This is useful if you have built the kernel with a different toolchain > > > to the system one, where the system objdump may fail to disassemble > > > vmlinux. > > > > > > Now this can be fixed with something like this: > > > > > > $ perf test --objdump llvm-objdump "object code reading" > > > > > > Signed-off-by: James Clark <james.clark@arm.com> > > > > There is also "perf config" for things like this. > > > > Reviewed-by: Ian Rogers <irogers@google.com> > > > > Thanks, > > Ian > > That seems a bit better for this use case so I added it in V2.
Have you posted it? > Thanks for the review. > > James
--
- Arnaldo
| |