lkml.org 
[lkml]   [2023]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT
From


On 11/8/23 07:34, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without the CRC_CCITT code, the new greybus driver fails to link:
>
> aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
> gb-beagleplay.c:(.text+0x158): undefined reference to `crc_ccitt'
> aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `gb_tty_receive':
> gb-beagleplay.c:(.text+0x5c4): undefined reference to `crc_ccitt'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/greybus/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
> index 033d31dbf3b8..ab81ceceb337 100644
> --- a/drivers/greybus/Kconfig
> +++ b/drivers/greybus/Kconfig
> @@ -20,6 +20,7 @@ if GREYBUS
> config GREYBUS_BEAGLEPLAY
> tristate "Greybus BeaglePlay driver"
> depends on SERIAL_DEV_BUS
> + select CRC_CCITT
> help
> Select this option if you have a BeaglePlay where CC1352
> co-processor acts as Greybus SVC.

Yes, same as my patch:
https://lore.kernel.org/lkml/20231031040909.21201-1-rdunlap@infradead.org/

I expect that Greg just hasn't gotten around to applying new patches/fixes yet.

--
~Randy

\
 
 \ /
  Last update: 2023-11-20 13:53    [W:0.045 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site