Messages in this thread | | | Date | Wed, 8 Nov 2023 13:04:46 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v4 05/53] perf machine thread: Remove exited threads by default |
| |
Em Mon, Nov 06, 2023 at 01:28:43PM +0200, Adrian Hunter escreveu: > On 2/11/23 19:56, Ian Rogers wrote: > > struct thread values hold onto references to mmaps, dsos, etc. When a > > thread exits it is necessary to clean all of this memory up by > > removing the thread from the machine's threads. Some tools require > > this doesn't happen, such as auxtrace events, perf report if offcpu > > events exist or if a task list is being generated, so add a > > symbol_conf value to make the behavior optional. When an exited thread > > is left in the machine's threads, mark it as exited. > > > > This change relates to commit 40826c45eb0b ("perf thread: Remove > > notion of dead threads"). Dead threads were removed as they had a > > reference count of 0 and were difficult to reason about with the > > reference count checker. Here a thread is removed from threads when it > > exits, unless via symbol_conf the exited thread isn't remove and is > > marked as exited. Reference counting behaves as it normally does. > > > > Signed-off-by: Ian Rogers <irogers@google.com> > > For auxtrace: > > Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Thanks, applied to perf-tools-next.
- Arnaldo
| |