Messages in this thread | | | Date | Wed, 8 Nov 2023 17:51:44 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH v2 net 0/7] qbv cycle time extension/truncation |
| |
Hi Faizal,
On Tue, Nov 07, 2023 at 06:20:16AM -0500, Faizal Rahim wrote: > According to IEEE Std. 802.1Q-2018 section Q.5 CycleTimeExtension, > the Cycle Time Extension variable allows this extension of the last old > cycle to be done in a defined way. If the last complete old cycle would > normally end less than OperCycleTimeExtension nanoseconds before the new > base time, then the last complete cycle before AdminBaseTime is reached > is extended so that it ends at AdminBaseTime. > > Changes in v2: > > - Added 's64 cycle_time_correction' in 'sched_gate_list struct'. > - Removed sched_changed created in v1 since the new cycle_time_correction > field can also serve to indicate the need for a schedule change. > - Added 'bool correction_active' in 'struct sched_entry' to represent > the correction state from the entry's perspective and return corrected > interval value when active. > - Fix cycle time correction logics for the next entry in advance_sched() > - Fix and implement proper cycle time correction logics for current > entry in taprio_start_sched() > > v1 at: > https://lore.kernel.org/lkml/20230530082541.495-1-muhammad.husaini.zulkifli@intel.com/
I like what came of this patch series. Thanks for following up and taking over. I have some comments on individual patches.
| |