lkml.org 
[lkml]   [2023]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 17/22] powerpc: ps3: move udbg_shutdown_ps3gelic prototype
From
Hi Arnd,

On 11/8/23 12:58, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Allmodconfig kernels produce a missing-prototypes warning:
>
> arch/powerpc/platforms/ps3/gelic_udbg.c:239:6: error: no previous prototype for 'udbg_shutdown_ps3gelic' [-Werror=missing-prototypes]
>
> Move the declaration from a local header to asm/ps3.h where it can be
> seen from both the caller and the definition.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/powerpc/include/asm/ps3.h | 6 ++++++
> arch/powerpc/platforms/ps3/gelic_udbg.c | 1 +
> drivers/net/ethernet/toshiba/ps3_gelic_net.h | 6 ------
> 3 files changed, 7 insertions(+), 6 deletions(-)

Seems good to me. I'll test it next chance I get.

Signed-off-by: Geoff Levand <geoff@infradead.org>


\
 
 \ /
  Last update: 2023-11-20 13:53    [W:0.221 / U:1.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site