lkml.org 
[lkml]   [2023]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add specific compatibles for existing SoC
    Date
    Samsung Exynos SoC reuses several devices from older designs, thus
    historically we kept the old (block's) compatible only. This works fine
    and there is no bug here, however guidelines expressed in
    Documentation/devicetree/bindings/writing-bindings.rst state that:
    1. Compatibles should be specific.
    2. We should add new compatibles in case of bugs or features.

    Add compatibles specific to each SoC in front of all old-SoC-like
    compatibles.

    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    ---

    I propose to take the patch through Samsung SoC (me). See cover letter
    for explanation.
    ---
    .../bindings/hwinfo/samsung,exynos-chipid.yaml | 17 ++++++++++++++---
    1 file changed, 14 insertions(+), 3 deletions(-)

    diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
    index 95cbdcb56efe..45f3d468db7c 100644
    --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
    +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
    @@ -11,9 +11,20 @@ maintainers:

    properties:
    compatible:
    - enum:
    - - samsung,exynos4210-chipid
    - - samsung,exynos850-chipid
    + oneOf:
    + - enum:
    + - samsung,exynos4210-chipid
    + - samsung,exynos850-chipid
    + - items:
    + - enum:
    + - samsung,exynos5433-chipid
    + - samsung,exynos7-chipid
    + - const: samsung,exynos4210-chipid
    + - items:
    + - enum:
    + - samsung,exynos7885-chipid
    + - samsung,exynosautov9-chipid
    + - const: samsung,exynos850-chipid

    reg:
    maxItems: 1
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-11-20 13:52    [W:3.243 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site