Messages in this thread | | | Date | Wed, 8 Nov 2023 16:46:03 +0800 | Subject | Re: [PATCH v2 5/7] scsi: ufs: ufs-qcom: Set initial PHY gear to max HS gear for HW ver 5 and newer | From | Can Guo <> |
| |
Hi Mani,
On 11/8/2023 1:34 PM, Manivannan Sadhasivam wrote: > On Mon, Nov 06, 2023 at 08:46:11PM -0800, Can Guo wrote: >> From: Can Guo <quic_cang@quicinc.com> >> >> Set the initial PHY gear to max HS gear for hosts with HW ver 5 and newer. >> > > How about, > > "For UFSHC >= 5.0, set the initial PHY gear based on the gear value returned by > ufs_qcom_get_hs_gear(). For the rest, use the existing default value of G2." >
It is much better, will improve in next version.
>> This patch is not changing any functionalities or logic but only a >> preparation patch for the next patch in this series. >> > > You are also moving the default phy_gear code to ufs_qcom_set_host_params(). So > it should be mentioned in the commit message. >
Sure.
Thanks, Can Guo.
| |