lkml.org 
[lkml]   [2023]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 5/5] mei: pxp: add dependency on Xe driver
On Tue, Nov 07, 2023 at 02:26:17PM +0000, Usyskin, Alexander wrote:
> >
> > On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> > > Optionally depend on either i915 or Xe drivers.
> > >
> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > > ---
> > > drivers/misc/mei/pxp/Kconfig | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> > > index 4029b96afc04..d9ae5483567f 100644
> > > --- a/drivers/misc/mei/pxp/Kconfig
> > > +++ b/drivers/misc/mei/pxp/Kconfig
> > > @@ -1,11 +1,10 @@
> > > -
> >
> > Why this change here?
>
> I've been told that SPDX should be the first line in the file,
> but here fist line is an empty line.

That is correct, and should be fixed up, but you didn't say that you
made this change in your changelog text so I didn't know why it was
there.

> I can drop this change if it is inappropriate to put it in this patch.

It should go in a separate patch please.

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-11-20 13:51    [W:0.055 / U:0.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site