lkml.org 
[lkml]   [2023]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH AUTOSEL 6.6 21/40] drm/radeon: Fix UBSAN array-index-out-of-bounds for Radeon HD 5430
On Tue, Nov 7, 2023 at 7:20 AM Sasha Levin <sashal@kernel.org> wrote:
>
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> [ Upstream commit c63079c61177ba1b17fa05c6875699a36924fe39 ]
>
> For pptable structs that use flexible array sizes, use flexible arrays.
>
> Suggested-by: Felix Held <felix.held@amd.com>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2894
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

FWIW, I don't think any of these UBSAN variable sized array changes
are really stable material. They are not really fixing an actual
issue just making UBSAN happy.

Alex


> ---
> drivers/gpu/drm/radeon/pptable.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/pptable.h b/drivers/gpu/drm/radeon/pptable.h
> index 4c2eec49dadc9..94947229888ba 100644
> --- a/drivers/gpu/drm/radeon/pptable.h
> +++ b/drivers/gpu/drm/radeon/pptable.h
> @@ -74,7 +74,7 @@ typedef struct _ATOM_PPLIB_THERMALCONTROLLER
> typedef struct _ATOM_PPLIB_STATE
> {
> UCHAR ucNonClockStateIndex;
> - UCHAR ucClockStateIndices[1]; // variable-sized
> + UCHAR ucClockStateIndices[]; // variable-sized
> } ATOM_PPLIB_STATE;
>
>
> --
> 2.42.0
>

\
 
 \ /
  Last update: 2023-11-20 13:51    [W:0.123 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site