lkml.org 
[lkml]   [2023]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 2/3] drivers: mfd: Add support for TPS65224 i2c driver
Date
From: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>

> On Thu, Oct 26, 2023 at 07:02:25PM +0530, Gairuboina Sirisha wrote:
> > From: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
> >
> > Added MFD driver that enables I2C communication with and without CRC
> >
> > Signed-off-by: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
> > ---
> > drivers/mfd/Kconfig | 14 +++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/tps65224-i2c.c | 245 +++++++++++++++++++++++++++++++++++++
> > 3 files changed, 260 insertions(+)
> > create mode 100644 drivers/mfd/tps65224-i2c.c
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 2e4906484eed..943d85d49fc5 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -1767,12 +1767,26 @@ config MFD_TPS6594_SPI
> >
> > This driver can also be built as a module. If so, the module
> > will be called tps6594-spi.
> > +
>
> That line should have been added in the first patch.
>
>
> > config MFD_TPS65224
> > tristate
> > select MFD_CORE
> > select REGMAP
> > select REGMAP_IRQ
> >
> > +config MFD_TPS65224_I2C
> > + tristate "TI TPS65224 Power Management chip with I2C"
> > + select MFD_TPS65224
> > + select REGMAP_I2C
> > + select CRC8
> > + depends on I2C
> > + help
> > + If you say yes here you get support for the TPS65224 series of
> > + PM chips with I2C interface.
> > +
> > + This driver can also be built as a module. If so, the module
> > + will be called tps65224-i2c.
> > +
> > config TWL4030_CORE
> > bool "TI TWL4030/TWL5030/TWL6030/TPS659x0 Support"
> > depends on I2C=y
> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> > index ff4e158fa4db..4963fecd3e93 100644
> > --- a/drivers/mfd/Makefile
> > +++ b/drivers/mfd/Makefile
> > @@ -103,6 +103,7 @@ obj-$(CONFIG_MFD_TPS6594) += tps6594-core.o
> > obj-$(CONFIG_MFD_TPS6594_I2C) += tps6594-i2c.o
> > obj-$(CONFIG_MFD_TPS6594_SPI) += tps6594-spi.o
> > obj-$(CONFIG_MFD_TPS65224) += tps65224-core.o
> > +obj-$(CONFIG_MFD_TPS65224) += tps65224-i2c.o
> > obj-$(CONFIG_MENELAUS) += menelaus.o
> >
> > obj-$(CONFIG_TWL4030_CORE) += twl-core.o twl4030-irq.o twl6030-irq.o
> > diff --git a/drivers/mfd/tps65224-i2c.c b/drivers/mfd/tps65224-i2c.c
> > new file mode 100644
> > index 000000000000..c6300138ce4c
> > --- /dev/null
> > +++ b/drivers/mfd/tps65224-i2c.c
> > @@ -0,0 +1,245 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * I2C access driver for TI TPS65224 PMIC
> > + *
> > + * Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com/
>
> Again, check your copyright lines please.

Will correct style and copyright issues in the next patch version V2.

Thanks & Regards,
Sirisha G.

\
 
 \ /
  Last update: 2023-11-20 13:51    [W:0.117 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site