lkml.org 
[lkml]   [2023]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Re: [PATCH 2/4] sched/eevdf: Sort the rbtree by virtual deadline
From
On 11/7/23 7:03 PM, Peter Zijlstra Wrote:
> On Tue, Nov 07, 2023 at 05:05:08PM +0800, Abel Wu wrote:
>
>> Sort the task timeline by virtual deadline and keep the min_vruntime
>> in the augmented tree, so we can avoid doubling the worst case cost
>> and make full use of the cached leftmost node to enable O(1) fastpath
>> picking in next patch.
>
> Another very good patch, just a note:
>
>> This patch also cleans up the unused max_vruntime() and adjusts pos
>> for some functions.
>
> There's this thing about saying 'this patch' in Changelogs, per
> definition the Changelog is about 'this patch' so saying it is a bit
> redundant.

I see, thanks.

>
> It even gets mentioned in the Documentation on submitting patches
> somewhere.
>
> But what I care about more is this patch doing extra unrelated things,
> this should be split out.

I will fix this in next version.

Thanks,
Abel

\
 
 \ /
  Last update: 2023-11-20 13:51    [W:0.059 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site