Messages in this thread | | | Subject | Re: [PATCH net v2] page_pool: Add myself as page pool reviewer in MAINTAINERS | From | Yunsheng Lin <> | Date | Wed, 8 Nov 2023 11:31:45 +0800 |
| |
On 2023/11/8 1:49, Jakub Kicinski wrote: > On Tue, 7 Nov 2023 20:38:24 +0800 Yunsheng Lin wrote: >> I have added frag support for page pool, made some improvement >> for it recently, and reviewed some related patches too. >> >> So add myself as reviewer so that future patch will be cc'ed >> to my email. > > Not sure what to do about this, it feels somewhat wrong to add > as a reviewer someone who seem to not follow our basic process > requirements: > > https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
I reread the above doc in order not to miss anything obvious again:(
I suppose basic process requirements mean: 1. designate your patch to a tree - [PATCH net] or [PATCH net-next] 2. don't repost your patches within one 24h period
For 1, somehow I got the impression that changing to MAINTAINERS can be targetted to net branch, so that the change can flow to other main trees quickly, maybe I was wrong?
For 2, yes, maybe I should stick to the rule even if it is a simple patch and obivous format error.
Please correct me if there is anything else I missed.
> > :( > > . >
| |