Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [RESEND v5 2/4] fs: debugfs: Add write functionality to debugfs blobs | Date | Tue, 7 Nov 2023 22:28:27 +0000 |
| |
> @@ -1042,7 +1060,7 @@ struct dentry *debugfs_create_blob(const char *name, umode_t mode, > struct dentry *parent, > struct debugfs_blob_wrapper *blob) > { > - return debugfs_create_file_unsafe(name, mode & 0444, parent, blob, &fops_blob); > + return debugfs_create_file_unsafe(name, mode, parent, blob, &fops_blob); > }
The minimalist change here would be to s/0444/0666/
That would just allow callers to ask for writeable files without letting them add execute permission, or exotic modes like setuid etc.
-Tony
| |