Messages in this thread | | | Date | Tue, 7 Nov 2023 22:29:50 +0100 | Subject | Re: [PATCH 7/8] arm64: dts: qcom: Add PM8937 PMIC | From | Konrad Dybcio <> |
| |
On 11/6/23 13:08, Dang Huynh wrote: > The PM8937 features integrated peripherals like ADC, GPIO controller, > MPPs, PON keys and others. > > Add the device tree so that any boards with this PMIC can use it. > > Signed-off-by: Dang Huynh <danct12@riseup.net> > --- > arch/arm64/boot/dts/qcom/pm8937.dtsi | 202 +++++++++++++++++++++++++++++++++++ > 1 file changed, 202 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm8937.dtsi b/arch/arm64/boot/dts/qcom/pm8937.dtsi > new file mode 100644 > index 000000000000..6091d6938885 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pm8937.dtsi > @@ -0,0 +1,202 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023, Dang Huynh <danct12@riseup.net> > + */ > + > +#include <dt-bindings/iio/qcom,spmi-vadc.h> > +#include <dt-bindings/input/linux-event-codes.h> > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/pinctrl/qcom,pmic-mpp.h> > +#include <dt-bindings/spmi/spmi.h> > + > +/ { > + thermal-zones { > + pm8937-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&pm8937_temp>; > + > + trips { > + pm8937_trip0: pm8937-trip0 { > + temperature = <105000>; > + hysteresis = <0>; > + type = "passive"; > + }; Add a newline between the subnodes, please
[...]
> + pm8937_resin: resin { > + compatible = "qcom,pm8941-resin"; > + interrupts = <0 0x8 1 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + linux,code = <KEY_VOLUMEDOWN>; This keycode varies per-device, please move it out
> + }; > + }; > + > + pm8937_gpios: gpio@c000 { > + compatible = "qcom,pm8937-gpio", "qcom,spmi-gpio"; > + reg = <0xc000>; > + gpio-controller; > + gpio-ranges = <&pm8937_gpios 0 0 8>; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + pm8937_mpps: mpps@a000 { > + compatible = "qcom,pm8937-mpp", "qcom,spmi-mpp"; > + reg = <0xa000>;
[...]
> + > + rtc@6000 { > + compatible = "qcom,pm8941-rtc"; > + reg = <0x6000>, <0x6100>; > + reg-names = "rtc", "alarm"; > + interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>; This is probably IRQ_TYPE_EDGE_RISING
Konrad
| |