Messages in this thread | | | From | Justin Chen <> | Date | Tue, 7 Nov 2023 10:48:13 -0800 | Subject | Re: net: bcmasp: Use common error handling code in bcmasp_probe() |
| |
On Mon, Nov 6, 2023 at 10:38 PM Markus Elfring <Markus.Elfring@web.de> wrote: > > >> Add a jump target so that a bit of exception handling can be better > >> reused at the end of this function. > … > >> --- > >> drivers/net/ethernet/broadcom/asp2/bcmasp.c | 10 ++++++---- > >> 1 file changed, 6 insertions(+), 4 deletions(-) > > > > The diffstat proves otherwise. > > Please don't send such patches to networking. > > How does this feedback fit to a change possibility which was reviewed by > Wojciech Drewek yesterday? > > Regards, > Markus
We are making the code harder to follow with these changes. Also adding more lines than removing. Don't think this patch is an improvement IMHO. NAK on my end.
Thanks, Justin [unhandled content-type:application/pkcs7-signature] | |