Messages in this thread | | | Date | Mon, 06 Nov 2023 03:11:09 +0000 | From | Rahul Rameshbabu <> | Subject | Re: [PATCH] HID: apple: add Jamesdonkey and A3R to non-apple keyboards list |
| |
On Mon, 30 Oct, 2023 01:05:38 +0800 "Yihong Cao" <caoyihong4@outlook.com> wrote: > Jamesdonkey A3R keyboard is identified as "Jamesdonkey A3R" in wired > mode, "A3R-U" in wireless mode and "A3R" in bluetooth mode. Adding them > to non-apple keyboards fixes function key. > > Signed-off-by: Yihong Cao <caoyihong4@outlook.com> > --- > drivers/hid/hid-apple.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c > index 3ca45975c686..d9e9829b2200 100644 > --- a/drivers/hid/hid-apple.c > +++ b/drivers/hid/hid-apple.c > @@ -345,6 +345,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = { > { "AONE" }, > { "GANSS" }, > { "Hailuck" }, > + { "Jamesdonkey" },
Sorry, maybe I misunderstood the commit message. In wired mode, if the keyboard is identified as "Jamesdonkey A3R", shouldn't this value be "Jamesdonkey A3R" instead of "Jamesdonkey"?
> + { "A3R" }, > }; > > static bool apple_is_non_apple_keyboard(struct hid_device *hdev)
-- Thanks,
Rahul Rameshbabu
| |