Messages in this thread | | | Subject | Re: [PATCH 10/10] ipmi: kcs_bmc: Add subsystem kerneldoc | From | Andrew Jeffery <> | Date | Mon, 06 Nov 2023 10:35:05 +1030 |
| |
On Fri, 2023-11-03 at 15:12 +0000, Jonathan Cameron wrote: > On Fri, 3 Nov 2023 16:45:22 +1030 > Andrew Jeffery <andrew@codeconstruct.com.au> wrote: > > > Provide kerneldoc describing the relationships between and the > > behaviours of the structures and functions of the KCS subsystem. > > > > Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au> > Seems reasonable but I've only a superficial idea of how this all fits > together so no tag from me.
Thanks for the reviews so far!
> > There is the fun question of whether function documentation should be > next to the implementation or in the header. As long as it's > consistent in a given subsystem I don't personally thing it matters > that much.
Happy to put it where people prefer. I like the consistency of having it all in the one spot, but I appreciate the idea that it might be easier to maintain alongside the implementation.
Andrew
| |