Messages in this thread | | | Subject | Re: [PATCH 03/10] ipmi: kcs_bmc: Make kcs_bmc_update_event_mask() static | From | Andrew Jeffery <> | Date | Mon, 06 Nov 2023 09:22:44 +1030 |
| |
On Fri, 2023-11-03 at 14:40 +0000, Jonathan Cameron wrote: > On Fri, 3 Nov 2023 16:45:15 +1030 > Andrew Jeffery <andrew@codeconstruct.com.au> wrote: > > > There were no users outside the subsystem core, so let's not expose it. > > > > Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au> > Is it worth having the wrapper?
Perhaps not, though aesthetically I prefer it. Also the diff is at least slightly smaller by not removing it entirely :)
> > I guess all the other cases do have wrappers (even if that's because > they continue to be exported) so fair enough. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Thanks,
Andrew
| |