Messages in this thread | | | Subject | Re: [PATCH 02/10] ipmi: kcs_bmc: Include spinlock.h | From | Andrew Jeffery <> | Date | Mon, 06 Nov 2023 09:17:26 +1030 |
| |
On Fri, 2023-11-03 at 14:36 +0000, Jonathan Cameron wrote: > On Fri, 3 Nov 2023 16:45:14 +1030 > Andrew Jeffery <andrew@codeconstruct.com.au> wrote: > > > struct kcs_bmc_device defines a spinlock member but the header in which > > it is defined failed to include the spinlock header. In the spirit of > > include-what-you-use, do what's necessary. > > > > Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au> > This is fine, but whilst checking it I noticed there is no > forwards def of struct device or appropriate include.
Ah, I'll fix that too.
clangd automatically added the spinlock include at one point and so I figured I'd capture it.
Andrew
| |