Messages in this thread | | | Date | Sun, 5 Nov 2023 14:39:19 +0100 | Subject | Re: [PATCH v2 2/2] dt-bindings: rtc: add pcf85053a | From | Krzysztof Kozlowski <> |
| |
On 03/11/2023 13:51, Carlos Menin wrote: > Add YAML bindings for NXP's PCF85053A RTC chip. > > Signed-off-by: Carlos Menin <menin@carlosaurelio.net> > Reviewed-by: Sergio Prado <sergio.prado@e-labworks.com>
Thank you for your patch. There is something to discuss/improve.
> + quartz-load-femtofarads: > + description: > + The capacitive load of the crystal, expressed in femto Farad (fF). > + enum: [6000, 7000, 12500] > + default: 12500 > + > + nxp,quartz-drive-control: > + description: > + The oscillator is designed to be used with quartz with a series resistance > + up to 100 kOhms. This covers the typical range of 32.768 kHz quartz > + crystals. A low drive mode is available for low series resistance quartz > + (up to 60 kOhms). This reduces the current consumption. For very high > + series resistance quartz (up to 500 kOhms), there is a high drive mode. > + Current consumption increases substantially in this mode. > + enum: [low, normal, high] > + default: normal > + > + nxp,low-jitter-mode: > + description: > + If set to true, will decrease the CLK output jitter, at the cost of > + increasing the current consumption. > + type: boolean > + default: false
Drop this line.
> + > + nxp,clk-inverted: > + description: > + Invert clock output. Normally, the low jitter mode reduces jitter on the > + rising edge of the output clock. If this property is set to true, then the > + low jitter mode will affect the falling edge of the output clock. > + type: boolean > + default: false > + > +required: > + - compatible > + - reg > + > +allOf: > + - $ref: rtc.yaml# > + > +additionalProperties: false
This should be rather unevaluatedProperties: false
> + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@6f { > + compatible = "nxp,pcf85053a"; > + reg = <0x6f>;
Please extend the example to include all or almost all properties (which make sense).
Best regards, Krzysztof
| |