Messages in this thread | | | Date | Sat, 4 Nov 2023 13:32:16 +0100 | Subject | Re: [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and rb3 board | From | Konrad Dybcio <> |
| |
On 11/3/23 19:46, Komal Bajaj wrote: > Add qcm6490 devicetree file for QCM6490 IDP and QCM6490 RB3 > platform. QCM6490 is derived from SC7280 meant for various > form factor including IoT. > > Supported features are, as of now: > * Debug UART > * eMMC (only in IDP) > * USB > > Co-developed-by: Naina Mehta <quic_nainmeht@quicinc.com> > Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com> > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- [...]
> + > +&sdhc_1 { > + non-removable; > + no-sd; > + no-sdio; > + > + vmmc-supply = <&vreg_l7b_2p952>; > + vqmmc-supply = <&vreg_l19b_1p8>; I think you also need to add regulator-allow-set-mode and something something regulator allowed modes to VQMMC
[...]
> + model = "Qualcomm Technologies, Inc. QCM6490 RB3"; Is the name just "QCM6490 RB3"? One already exists, based on SDM845.
Otherwise, this looks very good to me now, thanks.
With these nits addressed:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
| |