lkml.org 
[lkml]   [2023]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64
From
On 2023-11-02 3:26 pm, Mark Brown wrote:
> On Thu, Nov 02, 2023 at 04:20:29PM +0100, Duje Mihanović wrote:
>> The SSPA driver currently seems to generate ARM32 assembly, which causes
>> build errors when building a kernel for an ARM64 ARCH_MMP platform.
>>
>> Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support")
>> Reported-by: kernel test robot <lkp@intel.com>
>
>> tristate "SoC Audio via MMP SSPA ports"
>> - depends on ARCH_MMP
>> + depends on ARCH_MMP && ARM
>
> This isn't a fix for the existing code, AFAICT the issue here is that
> ARCH_MMP is currently only available for arm and presumably something in
> the rest of your series makes it available for arm64. This would be a
> prerequisite for that patch.
>
> Please don't just insert random fixes tags just because you can.

FWIW it doesn't even seem to be the right reason either. AFACIT the
issue being introduced is that SND_MMP_SOC_SSPA selects SND_ARM which
depends on ARM, but after patch #8 ARCH_MMP itself will no longer
necessarily imply ARM. The fact that selecting SND_ARM with unmet
dependencies also allows SND_ARMAACI to be enabled (which appears to be
the only thing actually containing open-coded Arm asm) is tangential.

Robin.

\
 
 \ /
  Last update: 2023-11-20 13:48    [W:1.531 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site